refactor: Function to get execution status stats#95
Open
yuechao-qin wants to merge 1 commit intomasterfrom
Open
refactor: Function to get execution status stats#95yuechao-qin wants to merge 1 commit intomasterfrom
yuechao-qin wants to merge 1 commit intomasterfrom
Conversation
Collaborator
Author
This was referenced Feb 17, 2026
yuechao-qin
changed the base branch from
ycq/count_execution_summary
to
graphite-base/95
yuechao-qin
force-pushed
the
ycq/function_get_execution_status_stats
branch
from
1229fcb to
f086771
Compare
yuechao-qin
force-pushed
the
graphite-base/95
branch
from
2dab4d8 to
b6873b2
Compare
yuechao-qin
changed the base branch from
graphite-base/95
to
ycq/count_execution_summary
yuechao-qin
changed the base branch from
ycq/count_execution_summary
to
graphite-base/95
yuechao-qin
force-pushed
the
ycq/function_get_execution_status_stats
branch
from
f086771 to
e2e05ef
Compare
yuechao-qin
force-pushed
the
graphite-base/95
branch
from
b6873b2 to
b18d382
Compare
yuechao-qin
changed the base branch from
graphite-base/95
to
ycq/count_execution_summary
yuechao-qin
changed the base branch from
ycq/count_execution_summary
to
graphite-base/95
yuechao-qin
force-pushed
the
graphite-base/95
branch
from
b18d382 to
546f75f
Compare
yuechao-qin
force-pushed
the
ycq/function_get_execution_status_stats
branch
from
e2e05ef to
e382bc8
Compare
yuechao-qin
force-pushed
the
ycq/function_get_execution_status_stats
branch
from
e382bc8 to
5ae141c
Compare
morgan-wowk
requested changes
Feb 23, 2026
Collaborator
morgan-wowk
left a comment
morgan-wowk
left a comment
There was a problem hiding this comment.
I can see that it is functionally the same from a production code point of view. Just left some comments on the tests.
Thanks for doing this!
| from cloud_pipelines_backend import database_ops | ||
| from cloud_pipelines_backend.api_server_sql import ( | ||
| ExecutionStatusSummary, | ||
| PipelineRunsApiService_Sql, |
Collaborator
There was a problem hiding this comment.
:nit
If we are treating test code with the same standard as production code then I'll just mention:
Alexey has asked me to import modules (api_server_sql) rather than directly importing classes or function.
So you would use api_server_sql.ExecutionStatusSummary rather than ExecutionStatusSummary directly in this file. Same with other imports.
Ark-kun
reviewed
Mar 3, 2026
| session.flush() | ||
|
|
||
|
|
||
| def _create_pipeline_run(session, root_execution, created_by=None, annotations=None): |
Contributor
There was a problem hiding this comment.
Let's use Python type annotations everywhere in function signatures.
Ark-kun
reviewed
Mar 3, 2026
| def _create_pipeline_run(session, root_execution, created_by=None, annotations=None): | ||
| """Helper to create a PipelineRun linked to a root execution node.""" | ||
| run = bts.PipelineRun(root_execution=root_execution) | ||
| if created_by: |
Contributor
There was a problem hiding this comment.
This conditionals are not needed. You can just construct the PipelineRun object.
Ark-kun
requested changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Refactored execution status stats calculation and added comprehensive tests for the pipeline runs API service.
What changed?
_get_execution_status_statsPipelineRunsApiService_SqlclassHow to test?
Run the new test cases in
tests/test_api_server_sql.py:Why make this change?
Created this function to be used in upstream PRs for Pipeline Run API (list and get)